Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/v2/comebft): wire missing services + fix simulation (backport #21964) #22555

Merged
merged 4 commits into from
Nov 19, 2024
Merged

fix(server/v2/comebft): wire missing services + fix simulation (backport #21964) #22555

merged 4 commits into from
Nov 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Description

Closes: #21958

IMPORTANT and discovered while working on this PR:

In v1, external grpc services were available to modules (comet services, node service, tx service)
In v2 they aren't, which is why we have a special handling for the tx service for simulation.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced gRPC service for querying node-related information, including a Config method to retrieve minimum gas prices.
    • Added support for transaction simulation and broadcasting via gRPC.

  • Improvements

    • Enhanced error handling across various methods for better robustness.
    • Streamlined function signatures for querying operations, simplifying the interface.

  • Bug Fixes

    • Improved error reporting for unknown query paths in the consensus module.

  • Chores

    • Updated dependency management in go.mod files to reflect new paths and versions.
This is an automatic backport of pull request #21964 done by [Mergify](https://mergify.com).

@julienrbrt @mergify
fix(server/v2/comebft): wire missing services + fix simulation (#21964)
919b35c 
(cherry picked from commit d697a3d)

# Conflicts:
#	server/v2/api/grpc/server.go
#	server/v2/cometbft/go.mod
#	server/v2/go.mod
#	server/v2/stf/branch/mergeiter.go
@mergify mergify bot requested a review from a team as a code owner November 19, 2024 13:56
@mergify mergify bot added the conflicts label Nov 19, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024

Cherry-pick of d697a3d has failed:

On branch mergify/bp/release/v0.52.x/pr-21964
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit d697a3de0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   api/cosmos/base/node/v2/query.pulsar.go
	new file:   api/cosmos/base/node/v2/query_grpc.pb.go
	modified:   client/grpc/cmtservice/service.go
	new file:   proto/cosmos/base/node/v2/query.proto
	new file:   server/v2/api/grpc/nodeservice/query.pb.go
	new file:   server/v2/api/grpc/nodeservice/query.pb.gw.go
	new file:   server/v2/api/grpc/nodeservice/service.go
	modified:   server/v2/cometbft/abci.go
	modified:   server/v2/cometbft/abci_test.go
	deleted:    server/v2/cometbft/client/grpc/cmtservice/autocli.go
	deleted:    server/v2/cometbft/client/grpc/cmtservice/service.go
	modified:   server/v2/cometbft/client/rpc/block.go
	modified:   server/v2/cometbft/client/rpc/utils.go
	new file:   server/v2/cometbft/grpc.go
	modified:   server/v2/cometbft/query.go
	modified:   server/v2/cometbft/server.go
	modified:   simapp/v2/simdv2/cmd/commands.go
	modified:   simapp/v2/simdv2/cmd/root_di.go
	modified:   tests/integration/accounts/base_account_test.go
	modified:   tests/integration/accounts/wiring_test.go
	modified:   x/staking/keeper/grpc_query.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   server/v2/api/grpc/server.go
	both modified:   server/v2/cometbft/go.mod
	deleted by us:   server/v2/go.mod
	deleted by us:   server/v2/stf/branch/mergeiter.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

@mergify[bot] your pull request is missing a changelog!

@julienrbrt julienrbrt self-assigned this Nov 19, 2024
@julienrbrt julienrbrt merged commit 3fcdcae into release/v0.52.x Nov 19, 2024
72 of 74 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-21964 branch November 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees

@julienrbrt julienrbrt

Labels
C:CLI C:server/v2 cometbft C:server/v2 Issues related to server/v2 C:x/protocolpool C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julienrbrt